On the TV the update stopped at "Bible App cannot be closed", and uninstalling
from Windows Settings showed "Installer integrity check has failed". The cause is
the uninstaller, not anything running.
An update runs the PREVIOUS version's uninstaller first. Versions 1.4.35-1.4.37
were built on macOS, where electron-builder can't run NSIS to write the uninstaller
and rebuilds it in JavaScript (UninstallerReader) from the installer's stub — without
NSIS's icon patch. makensis computes the uninstaller's CRC over the stub WITH the
uninstaller icon in it, so whenever the two icons differ the result fails NSIS's
integrity check. With no app icon configured, NSIS uses its two different default
icons, so every Mac-built uninstaller was damaged. Verified with a reimplementation
of NSIS's loadHeaders() check: the shipped installers pass; the captured uninstaller
failed (0x4235c8f5 vs stored 0x90f7de2c) and passes with this fix (0xb37e533c).
- build/installerIcon.ico: NSIS's own default install icon, so electron-builder uses
ONE icon for installer and uninstaller (nothing looks different; the app's icon is
unchanged). tools/build-win.cjs refuses to build without it.
- build/installer.nsh: for installs of 1.4.35-1.4.37 only, clear the old
UninstallString so the damaged uninstaller is not run; the new files are copied over
the old ones and a fresh, valid uninstaller is written. Every other version keeps
the normal uninstall-then-install path.
- BUILD-AND-DEPLOY.md: why the icon file must stay.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Updating 1.4.35 -> 1.4.36 on the TV stopped at "Bible App cannot be closed. Please
close it manually and click Retry" with the app plainly closed. That message also
comes from the installer's copy step (and from removing the old version) when any
file in the install folder is in use — not only when Bible App.exe is running.
The app runs programs from its own folder: the local AI server (llama-server.exe),
speech (whisper-cli.exe), the upscaler. electron-builder's stock check closes only
Bible App.exe, and when it has to force-close the app, the app's own shutdown (which
stops the AI server) never runs. The orphaned llama-server.exe then holds its files
open forever, so Retry can never succeed.
- build/installer.nsh: customCheckAppRunning replaces the stock check. It asks the
app to close, force-closes any Bible App.exe left, force-closes the helpers by name,
then, as a backstop, every process whose executable is inside the install folder
(via WMI, which works from the 32-bit installer on 64-bit Windows; the folder is
passed in an environment variable and a bare drive is refused). It runs before the
old version is removed and before any file is copied.
- main.cjs: the in-app updater stops the AI server before launching the installer.
The fix is in the INSTALLER, so the TV still on 1.4.35 gets it with this release.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
First commit on the local Gitea server, made after moving the tree off the
Windows machine. Build outputs, node_modules and the AI models stay out
(see .gitignore); everything the installer build needs is tracked.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
christianandClaude Opus 5.5