The English switch did nothing, so English could not be turned off
Build 125. Reported from the desk: every language on the listener page can be
switched off except English.
Exactly right, and it was not subtle. renderFeatured() unshifted the SOURCE
language into the list on every render, whatever the operator had chosen:
if (list.indexOf(app.cfg.sourceLanguage) === -1)
list.unshift(app.cfg.sourceLanguage);
So English was not merely on, it was always FIRST — the leading button on the
page — on a desk whose saved list was ["spa_Latn","por_Latn","por_PT","spa_ES"]
with English deliberately off and allowAll false. The operator had turned it
off, the config recorded that it was off, and the page put it back anyway.
The reasoning behind it was sound: people do want the English captions for
accessibility rather than translation. But that is a choice for the desk, not
for this function, and the switch to make it is already there in Settings next
to every other language. English is in the catalogue (languages.js:19) and the
operator window reads that same file, so turning it back on is one click.
A control that silently refuses is worse than no control. The operator's list
is now the list.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
@@ -163,10 +163,21 @@
|
||||
function renderFeatured() {
|
||||
var wrap = $('featured');
|
||||
wrap.textContent = '';
|
||||
/*
|
||||
* THE OPERATOR'S LIST IS THE LIST. This used to unshift the source
|
||||
* language in unconditionally, on the reasoning that plenty of people want
|
||||
* the English captions for accessibility rather than translation — which
|
||||
* is true, and still available, but it is not this code's call to make.
|
||||
* The operator has a switch for every language including English, and for
|
||||
* the source language alone that switch did nothing: English was put back
|
||||
* on every render, so a desk that had deliberately turned it off still
|
||||
* offered it as the first button on the page. A control that silently
|
||||
* refuses is worse than no control.
|
||||
*
|
||||
* Wanting English captions is now one click in Settings, in the same list
|
||||
* as every other language, and it stays where it is put.
|
||||
*/
|
||||
var list = (app.cfg.featured || []).slice();
|
||||
/* The source language belongs in the list too — plenty of people want the
|
||||
English captions for accessibility, not translation. */
|
||||
if (list.indexOf(app.cfg.sourceLanguage) === -1) list.unshift(app.cfg.sourceLanguage);
|
||||
list.forEach(function (code) {
|
||||
var b = langButton(code);
|
||||
if (b) wrap.appendChild(b);
|
||||
|
||||
Reference in New Issue
Block a user